WIP: Lambda invocation loop rework by dominikschubert · Pull Request #8508 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

WIP: Lambda invocation loop rework#8508

Closed
dominikschubert wants to merge 61 commits into
masterfrom
lambda-invocation-loop-rework
Closed

WIP: Lambda invocation loop rework#8508
dominikschubert wants to merge 61 commits into
masterfrom
lambda-invocation-loop-rework

Conversation

@dominikschubert

@dominikschubert dominikschubert commented Jun 15, 2023

Copy link
Copy Markdown
Member

@dominikschubert dominikschubert added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jun 15, 2023
@dominikschubert dominikschubert force-pushed the lambda-invocation-loop-rework branch from ea563d0 to 4fb0409 Compare July 11, 2023 09:06
@dominikschubert dominikschubert added this to the 3.0 milestone Jul 12, 2023
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch 3 times, most recently from b769c9d to d476257 Compare August 8, 2023 10:17
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch 2 times, most recently from 473a900 to 9a161c3 Compare August 10, 2023 11:16
@github-actions

github-actions Bot commented Aug 10, 2023

Copy link
Copy Markdown

@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch from 9a161c3 to 9afa186 Compare August 10, 2023 12:12
joe4dev and others added 26 commits August 23, 2023 10:27
The previous version of the test assumed that every failing Lambda invocation triggers the DLQ.
However, that only happends if the maximum number of retries are exhausted.
Adjusting the number of retries speeds up and fixes this test.
The goal is to minimize the number of tests that require custom AWS quota adjustments.

* Separated limits testing because monkeypatching allows edge case testing with LocalStack.
* Fixed the scenario `put_function_concurrency_qualified_arn_exc`, which accidentially suffered from another AWS account-specific limits snapshot.
Revert CI config to master
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch from 35b62e8 to cb21d7f Compare August 23, 2023 08:47
@joe4dev

joe4dev commented Aug 23, 2023

Copy link
Copy Markdown
Member

will re-open as a separate one

@joe4dev joe4dev closed this Aug 23, 2023
@joe4dev

joe4dev commented Aug 23, 2023

Copy link
Copy Markdown
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants