Fix mapping of denied access in docker hub by dfangl · Pull Request #8215 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix mapping of denied access in docker hub#8215

Merged
dfangl merged 1 commit into
masterfrom
fix-access-denied-exc-mapping
Apr 27, 2023
Merged

Fix mapping of denied access in docker hub#8215
dfangl merged 1 commit into
masterfrom
fix-access-denied-exc-mapping

Conversation

@dfangl

@dfangl dfangl commented Apr 27, 2023

Copy link
Copy Markdown
Member

Motivation

We are currently seeing error messages in the community test pipeline in -ext which indicate an error when verifying the access denied error of a docker push.

-------------------------------- live log call ---------------------------------
2023-04-27T11:45:30.758 DEBUG --- [  MainThread] localstack.utils.container_utils.docker_cmd_client : Pushing image with cmd: ['docker', 'push', 'alpine']
2023-04-27T11:45:30.758 DEBUG --- [  MainThread] localstack.utils.run       : Executing command: ['docker', 'push', 'alpine']
ERROR: '['docker', 'push', 'alpine']': exit code 1; output: b'Using default tag: latest\nThe push refers to repository [docker.io/library/alpine]\nf1417ff83b31: Preparing\nf1417ff83b31: Retrying in 5 seconds\nf1417ff83b31: Retrying in 4 seconds\nf1417ff83b31: Retrying in 3 seconds\nf1417ff83b31: Retrying in 2 seconds\nf1417ff83b31: Retrying in 1 second\nf1417ff83b31: Retrying in 10 seconds\nf1417ff83b31: Retrying in 9 seconds\nf1417ff83b31: Retrying in 8 seconds\nf1417ff83b31: Retrying in 7 seconds\nf1417ff83b31: Retrying in 6 seconds\nf1417ff83b31: Retrying in 5 seconds\nf1417ff83b31: Retrying in 4 seconds\nf1417ff83b31: Retrying in 3 seconds\nf1417ff83b31: Retrying in 2 seconds\nf1417ff83b31: Retrying in 1 second\nf1417ff83b31: Retrying in 15 seconds\nf1417ff83b31: Retrying in 14 seconds\nf1417ff83b31: Retrying in 13 seconds\nf1417ff83b31: Retrying in 12 seconds\nf1417ff83b31: Retrying in 11 seconds\nf1417ff83b31: Retrying in 10 seconds\nf1417ff83b31: Retrying in 9 seconds\nf1417ff83b31: Retrying in 8 seconds\nf1417ff83b31: Retrying in 7 seconds\nf1417ff83b31: Retrying in 6 seconds\nf1417ff83b31: Retrying in 5 seconds\nf1417ff83b31: Retrying in 4 seconds\nf1417ff83b31: Retrying in 3 seconds\nf1417ff83b31: Retrying in 2 seconds\nf1417ff83b31: Retrying in 1 second\nf1417ff83b31: Retrying in 20 seconds\nf1417ff83b31: Retrying in 19 seconds\nf1417ff83b31: Retrying in 18 seconds\nf1417ff83b31: Retrying in 17 seconds\nf1417ff83b31: Retrying in 16 seconds\nf1417ff83b31: Retrying in 15 seconds\nf1417ff83b31: Retrying in 14 seconds\nf1417ff83b31: Retrying in 13 seconds\nf1417ff83b31: Retrying in 12 seconds\nf1417ff83b31: Retrying in 11 seconds\nf1417ff83b31: Retrying in 10 seconds\nf1417ff83b31: Retrying in 9 seconds\nf1417ff83b31: Retrying in 8 seconds\nf1417ff83b31: Retrying in 7 seconds\nf1417ff83b31: Retrying in 6 seconds\nf1417ff83b31: Retrying in 5 seconds\nf1417ff83b31: Retrying in 4 seconds\nf1417ff83b31: Retrying in 3 seconds\nf1417ff83b31: Retrying in 2 seconds\nf1417ff83b31: Retrying in 1 second\nunknown: requesting higher privileges than access token allows\n'
RERUN

While it is not clear why there are different error messages returned here, we still have to map this return to AccessDenied (as it effectively is).

Changes

  • Add case of requesting higher privileges than access token allows to be mapped to a AccessDenied exception

@dfangl dfangl requested a review from alexrashed April 27, 2023 14:17
@dfangl dfangl requested a review from dominikschubert as a code owner April 27, 2023 14:17

@alexrashed alexrashed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! LGTM! 🚀 🦸🏽

@github-actions

Copy link
Copy Markdown

@dfangl dfangl merged commit 3716e92 into master Apr 27, 2023
@dfangl dfangl deleted the fix-access-denied-exc-mapping branch April 27, 2023 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants