localstack · dominikschubert · Feb 3, 2023 · Feb 2, 2023 · Feb 2, 2023 · Feb 3, 2023
diff --git a/localstack/packages/core.py b/localstack/packages/core.py
@@ -106,6 +106,7 @@ def _install(self, target: InstallTarget) -> None:
         archive_name = os.path.basename(download_url)
         download_and_extract(
             download_url,
+            retries=3,
             tmp_archive=os.path.join(config.dirs.tmp, archive_name),
             target_dir=target_directory,
         )

diff --git a/localstack/utils/archives.py b/localstack/utils/archives.py
@@ -185,12 +185,26 @@ def download_and_extract(archive_url, target_dir, retries=0, sleep=3, tmp_archiv
     if not os.path.exists(tmp_archive) or os.path.getsize(tmp_archive) <= 0:
         # create temporary placeholder file, to avoid duplicate parallel downloads
         save_file(tmp_archive, "")
+
         for i in range(retries + 1):
             try:
                 download(archive_url, tmp_archive)
                 break
-            except Exception:
-                time.sleep(sleep)
+            except Exception as e:
+                LOG.warning(
+                    "Attempt %d. Failed to download archive from %s: %s",
+                    i + 1,
+                    archive_url,
+                    e,
+                )
+                # only sleep between retries, not after the last one
+                if i < retries:
+                    time.sleep(sleep)
+
+    # if the temporary file we created above hasn't been replaced, we assume failure
+    if os.path.getsize(tmp_archive) <= 0:
+        raise Exception("Failed to download archive from %s: . Retries exhausted", archive_url)
+
     if ext == ".zip":
         unzip(tmp_archive, target_dir)
     elif ext in (