Support lambda docker flags in the asf provider by dfangl · Pull Request #7379 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Support lambda docker flags in the asf provider#7379

Merged
dfangl merged 2 commits into
masterfrom
lambda-docker-flags
Dec 21, 2022
Merged

Support lambda docker flags in the asf provider#7379
dfangl merged 2 commits into
masterfrom
lambda-docker-flags

Conversation

@dfangl

@dfangl dfangl commented Dec 21, 2022

Copy link
Copy Markdown
Member

Motivation

We already got multiple requests (e.g. https://discuss.localstack.cloud/t/nodejs-remote-debugging-with-provider-override-lambda-asf/185/2) for the flag to be supported again, as it is used in multiple debugging setups.

Changes

  • Allow lambda docker flags to be present again
  • Add test to developer tools which verifies the correct usage (of at least the environment flag)

@dfangl dfangl temporarily deployed to localstack-ext-tests December 21, 2022 17:14 — with GitHub Actions Inactive

@dominikschubert dominikschubert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to keep this option 👍

@dfangl dfangl temporarily deployed to localstack-ext-tests December 21, 2022 18:15 — with GitHub Actions Inactive
@coveralls

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@dfangl dfangl merged commit 09ce620 into master Dec 21, 2022
@dfangl dfangl deleted the lambda-docker-flags branch December 21, 2022 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants