{{ message }}
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
S3: fix validation parity of PutBucketNotificationConfiguration#13091
Merged
Conversation
bentsku
added
aws:s3
S3 Image Test Results (AMD64 / ARM64) 2 files ±0 2 suites ±0 7m 45s ⏱️ -12s Results for commit a33e99d. ± Comparison against base commit 3a06ba7. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 25m 37s ⏱️ Results for commit a33e99d. ♻️ This comment has been updated with latest results. |
bentsku
force-pushed
the
fix-s3-internal-errors
branch
from
6f8a9c8 to
a33e99d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While looking at error reports, I've spotted the following:
This indicates a key access to a non-existent key. Looking at the code, I could spot where we had an unsafe access to the
filter_rule["Name"](https://docs.aws.amazon.com/AmazonS3/latest/API/API_FilterRule.html).Validated with AWS, I could check that those fields were indeed mandatory and not optional.
I've taken the opportunity to remove a very old util we had added when doing the S3 migration to ASF (before, you had to manually attach additional fields that were not part of the spec, but this got fixed with #6865), so I removed the utility and used the proper exception which makes it much more readable.
Changes
_create_invalid_argument_excutility and properly used the exception insteadcompletes FLC-38