{{ message }}
Repository navigation
Support full URLs in API host configuration - #185
Open
CharlesYXW wants to merge 1 commit into
Open
CharlesYXW wants to merge 1 commit into
CharlesYXW wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Support full URLs in
api_host, following the behavior discussed in #157:host:portinputs, IPv6 addresses, encoded reverse-proxy path prefixes and query strings.Validation
pytest tests -m 'not lmstudio' -q: 207 passed, 202 deselected, including 30 new offline cases.ruff check --config pyproject.toml src/lmstudio/json_api.py src/lmstudio/sync_api.py src/lmstudio/async_api.py tests/test_api_host_urls.py: passed.ruff format --config pyproject.toml --checkon the same four files: passed.mypy --stricton the same four files: passed.Checked on macOS with Python 3.12.13 and the locked pytest 8.4.1 / Ruff 0.12.10 versions. No live LM Studio server or TLS reverse proxy was used; those integration tests remain unverified locally. No custom TLS configuration is introduced.
Prepared with Codex assistance and independently reviewed, including the actual sync/async HTTPX transport paths with network access blocked.
Fixes #157