{{ message }}
Repository navigation
websocket reconnection and memory leak cleanup - #172
Open
InboraStudio wants to merge 1 commit into
Open
InboraStudio wants to merge 1 commit into
InboraStudio wants to merge 1 commit into
Conversation
okay so websockets weren't reconnecting on failures and channels were leaking memory when cleanup failed. added auto retry with exponential backoff (3 tries by default) and made the cleanup methods more defensive so they don't crash on errors anymore. basically just making this more resilient for long running apps
Author
|
I have read the CLA Document and I hereby sign the CLA |
github-actions
Bot
added
the
CLA signed
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
okay so websockets weren't reconnecting on failures and channels were leaking memory when cleanup failed. added auto retry with exponential backoff (3 tries by default) and made the cleanup methods more defensive so they don't crash on errors anymore. basically just making this more resilient for long running apps yeah