{{ message }}
Open
Conversation
…ard if stream already exists
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…coped fixture for deterministic execution
sjer-akamai
requested review from
mawilk90 and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class SDK support for the Monitor Logs API (Destinations + Streams), including object models, Monitor group helpers, and accompanying unit/integration test coverage with CI workflow knobs for long-running stream provisioning.
Changes:
- Introduces
LogsDestination*andLogsStream*objects (including history + destination update support) inlinode_api4/objects/monitor.py. - Adds
MonitorGroup.destinations(),destination_create(),streams(), andstream_create()inlinode_api4/groups/monitor.py. - Adds unit tests, integration tests (with capability + env-var gating), fixtures, and updates e2e workflows to pass
RUN_ACLP_LOGS_STREAM_TESTS.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds support for monitor logs functionality
What does this PR do and why is this change necessary?
run_aclp_logs_stream_tests) needs to be set astrueoryesto enable testing the Stream portion of the API.run_aclp_logs_stream_testsenvironment variable.Notes:
✔️ How to Test
How do I run the relevant unit/integration tests?
Unit tests:
pytest test/unitto run all unit tests, or:pytest test/unit/objects/monitor_test.pyto run only monitor related testsIntegration tests:
export LINODE_TOKEN="YOUR_REAL_TOKEN"export RUN_ACLP_LOGS_STREAM_TESTS=truemake TEST_CASE=test_monitor_logs test-intNotes:
aclp_logsaccount capability