{{ message }}
Ensure stale branch are not taken into account by --include-paths#104
Merged
RomainCscn merged 2 commits intoJun 9, 2026
Conversation
axelniklasson
approved these changes
Jun 9, 2026
| const branchName = extractBranchNameFromMergeMessage(message) ?? extractBranchName(rawDecorations); | ||
|
|
||
| return { sha: sha.trim(), branchName, message }; | ||
| // Drop grafted/shallow-boundary parents so a shallow clone doesn't misreport a |
Collaborator
There was a problem hiding this comment.
What is a grafted/shallow-boundary parent? Having some trouble wrapping my head around this.
Collaborator
Author
There was a problem hiding this comment.
Made this clearer!
Collaborator
There was a problem hiding this comment.
Big nit: Could we drop references to #62 here and in the comments? Ideally we keep comments and tests self explanatory so we don't have to link out to a GitHub PR.
RomainCscn
deleted the
romain/lin-74544--include-paths-over-attributes-issues-from-stale-branch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
--include-pathsover-attributes issues from stale-branch merges (closes #102)When you scope a release to a folder, the tool was crediting it with issues from branches that never touched that folder.
Why: to decide if a merge belongs to the folder, it checked whether the folder "changed" across the merge (
--full-history, from #62). But a stale branch — cut from oldmainand merged late without rebasing — makes the folder look changed because of other work that landed onmainmeanwhile, not because of the branch itself. So the merge slips through the filter and its branch-name issue key gets attributed to a folder it never touched.Example
Web release runs
sync --include-paths="apps/web/**".ENG-2100is a backend-only branch, merged after the web app moved on:["ENG-2100"]❌ (backend issue on the web release)[]✅Fix
Before crediting a merge, ask git what the merge itself changed in the folder (
git diff <merge> vs. the commit just before it, limited to the folder):