docs: add `limactl mcp` to the command reference by Sarthak-Shreshtha01 · Pull Request #5608 · lima-vm/lima · GitHub
Skip to content

docs: add limactl mcp to the command reference - #5608

Open
Sarthak-Shreshtha01 wants to merge 5 commits into
lima-vm:masterfrom
Sarthak-Shreshtha01:fix/issue-5606
Open

Sarthak-Shreshtha01 wants to merge 5 commits into
lima-vm:masterfrom
Sarthak-Shreshtha01:fix/issue-5606

Conversation

@Sarthak-Shreshtha01

@Sarthak-Shreshtha01 Sarthak-Shreshtha01 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The reference pages at https://lima-vm.io/docs/reference/ are made only from limactl, so the commands of the limactl mcp and limactl menu plugins were missing. Both plugins now have a hidden generate-doc --content-mode=cli DIR that writes their pages, and limactl generate-doc --type docsy runs it for each plugin installed with limactl that supports it, so no plugin names are hardcoded. limactl-mcp generate-doc DIR still writes mcp.md by default. The docsy page code is shared in pkg/gendoc. The related tests pass, including the new TestGenDocContentModeCLI for both plugins.

Fixes #5606

`limactl-mcp generate-doc` now also writes the cli-reference pages
(`--cli-dir`), and `make docsy` puts them next to the `limactl` pages.
The plugin uses the display name `limactl mcp`, so the pages and the
usage show `limactl mcp` instead of `limactl-mcp`.

Fixes lima-vm#5606

Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread cmd/limactl-mcp/main.go
@AkihiroSuda AkihiroSuda added documentation Improvements or additions to documentation area/mcp labels Oct 13, 2026
@AkihiroSuda AkihiroSuda added this to the v2.3.0 milestone Oct 13, 2026
`limactl generate-doc --type docsy` now discovers the plugins installed
next to limactl, and runs `generate-doc --cli-dir DIR` for each plugin
that supports this flag. Plugin names are no longer hardcoded in the
Makefile.

The DIR argument of `limactl-mcp generate-doc` is now optional.

Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
@AkihiroSuda
AkihiroSuda self-requested a review October 15, 2026 06:18
Comment thread cmd/limactl-mcp/main.go Outdated
Comment thread cmd/limactl/gendoc.go
…mactl menu

Keep the DIR argument of `limactl-mcp generate-doc` and switch it to the
cli-reference pages with `--content-mode=cli`. `limactl-menu` gets the
same hidden command, so `limactl menu` is documented too. The docsy
page generation is shared in pkg/gendoc.

Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

PATH name collisions can silently exclude bundled plugins from command reference generation.

1 open finding

🧠 Review effort: Balanced

Comment thread cmd/limactl/gendoc.go Outdated
… pages

A limactl-mcp in $PATH was picked by plugins.Discover before the copy in
libexec/lima, and bundledPlugins then dropped it, so the mcp pages were
silently missing. DiscoverBundled only scans the directories next to
limactl and libexec/lima.

Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
@AkihiroSuda
AkihiroSuda requested a balanced review from Copilot October 18, 2026 05:45
@AkihiroSuda

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues remain; the Makefile disables parallel recipe execution, preventing the reported race.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@Sarthak-Shreshtha01

Copy link
Copy Markdown
Contributor Author

I will squash the commits into a single commit.

@AkihiroSuda

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/mcp documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://lima-vm.io/docs/reference/ does not contain the reference for limactl mcp

3 participants