{{ message }}
Repository navigation
fix(analyse): position review mistakes button under active POV and use explicit side labels - #22095
Draft
kaushalrog wants to merge 7 commits into
Draft
kaushalrog wants to merge 7 commits into
kaushalrog wants to merge 7 commits into
Conversation
… summary Fixes lichess-org#21946. The 'Learn from your mistakes' CTA was previously hardcoded directly between the White and Black summaries, making it appear underneath White even when viewing from Black's perspective and reviewing Black's mistakes. Now render the button directly beneath the summary corresponding to bottomColor.
Fixes lichess-org#21947. Rather than showing generic 'Learn from your mistakes', label the action 'Review white\'s mistakes' or 'Review black\'s mistakes' based on current board orientation / POV, clarifying whose moves are being reviewed.
Reflect the specific side being reviewed in the retro box header title
('Review white\'s mistakes' / 'Review black\'s mistakes') instead of generic
'Learn from your mistakes'.
The action menu button for launching retrospective review now explicitly states which side's mistakes will be analyzed, matching the active orientation.
Keep blind-mode / NVUI accessibility toggle consistent with the rest of the analysis UI by announcing 'Review white\'s mistakes' or 'Review black\'s mistakes'.
Centralize the logic for determining the localized retrospective review action string based on color to prevent duplication across views.
…ew button Add aria-label and role='button' attributes to the review mistakes anchor button to ensure screen readers unambiguously announce the action and target side.
Collaborator
ornicar
marked this pull request as draft
October 19, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR improves the analysis board UX and accessibility when reviewing mistakes:
roundTraining.ts, making it always appear underneath White even when viewing the board from Black's perspective. It is now positioned directly beneath the player summary matching the active board orientation (bottomColor).i18n.site.reviewWhiteMistakesandi18n.site.reviewBlackMistakesacross the summary CTA, the action menu, the retro box header, and the NVUI blind-mode view.role="button"and an explicitaria-labelto the review button so screen readers announce the exact target side.Related Issues
AI Contribution Disclosure