{{ message }}
Fix narrow embedded LPV movetext layout#20773
Open
markoub wants to merge 1 commit into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #16977.
What changed
showMoves: autoLPV embeds at widths up to 500px so the movetext panel does not keep the side-by-side minimum width.Proof
At a 420px embedded LPV viewport, the old CSS kept the stacked movetext panel at 200px wide. With this patch, the same rendered fixture gives a 420px movetext panel and no horizontal document overflow.
Measured with Chromium against compiled
bits.lpvCSS:Validation
./ui/build bits --no-installpnpm exec stylelint ui/bits/css/build/bits.lpv.scsspnpm exec oxfmt --check ui/bits/css/build/bits.lpv.scssgit diff --check origin/master...HEADAI assistance disclosure
I used OpenAI Codex to inspect the reported LPV embed layout issue, locate the relevant Sass entrypoint, implement this scoped CSS change, run the local validation commands above, and generate the manual Chromium proof image. I reviewed the final diff and can explain each line.