{{ message }}
Implemented parameters for Diff.find_similar()#396
Merged
Conversation
Diff.find_similar now supports the parameters that are exposed by libgit2's git_diff_find_similar. Parameters supported are rename_threshold, copy_threshold, rename_from_rewrite_threshold, break_rewrite_threshold and rename_limit
Closed
Author
Member
There was a problem hiding this comment.
All of these values will be unitialised if they're not passed. Instead of this, you should let PyArg_ParseTupleAndKeywords write into the options structure directly.
Author
There was a problem hiding this comment.
Thanks!
I actually figured that out myself but forgot to commit and push it... Thanks for the heads-up!
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff.find_similar now supports the parameters that are exposed by libgit2's git_diff_find_similar.
Parameters supported are rename_threshold, copy_threshold,
rename_from_rewrite_threshold, break_rewrite_threshold and rename_limit