{{ message }}
Repository navigation
Wrong binary state of a delta if patches have not been iterated #962
Description
Much to my surprise reading delta.is_binary returns the wrong value if one does not iterate over the patches beforehand. Given
mkdir test && cd test
touch README.md
dd if=/dev/urandom of=data.bin bs=256K count=1
git init .
git add README.md && git commit -m "initial"
git add data.bin && git commit -m "binary"this script
import pygit2
repo = pygit2.Repository('.git')
diff = repo.diff('HEAD', 'HEAD~1')
for delta in diff.deltas:
print(delta.is_binary)
for patch in diff:
pass
for delta in diff.deltas:
print(delta.is_binary)prints
False
True
Activity
Fixes libgit2#962: First create a git_patch to get delta->flags corre…
DiffDelta.is_binary may return None
py-pygit2: update to 1.10.1.
py-pygit2: update to 1.10.1.
Load DiffDelta binary flags lazily