{{ message }}
Repository navigation
Conversation
Closing the ssh process pipes and freeing git_process does not wait for the child on Unix. Long-running clients accumulate a zombie after every connection. Wait for the child after closing the pipes, retrying interrupted waits. Add a local fake-ssh regression test that connects and disconnects three times and verifies that each child has already been reaped. Fixes: libgit2#7437 Assisted-by: Codex:GPT-6 Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each SSH exec connection leaves a zombie child on Unix because closing the process pipes and freeing the process object never calls
waitpid. Repeated fetches in a long-running client therefore accumulate unreaped SSH children.Wait for the child after closing its pipes, retrying interrupted waits. The regression test uses a local fake SSH executable, connects and disconnects three times, and verifies that every child has already been reaped. It fails on the unmodified code and passes with this change.
Validation on Fedora AArch64: all 70 selected transport, clone-transport, and remote tests pass. No SSH server is needed.
Fixes #7437.