[WIP] Travis Mac SSH key issues by carlosmn · Pull Request #3954 · libgit2/libgit2 · GitHub
Skip to content

[WIP] Travis Mac SSH key issues#3954

Merged
carlosmn merged 2 commits into
masterfrom
cmn/osx-ssh-key
Oct 5, 2016
Merged

[WIP] Travis Mac SSH key issues#3954
carlosmn merged 2 commits into
masterfrom
cmn/osx-ssh-key

Conversation

@carlosmn

@carlosmn carlosmn commented Oct 5, 2016

Copy link
Copy Markdown
Member

We're failing this check and I'm trying to figure out why. It might just be that the format from ssh-keygen changed so we need to account for that in our tests.

This lets us see the details of what we're doing instead of just seeing the
output of unknown commands in the build output.
@carlosmn

carlosmn commented Oct 5, 2016

Copy link
Copy Markdown
Member Author

The Mac machines have updated their SSH version and so the ssh-keygen
format has changed. Ask it for MD5, which is the one that is output as
hex.

@arthurschreiber arthurschreiber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@carlosmn carlosmn merged commit e8ab13b into master Oct 5, 2016
@carlosmn carlosmn deleted the cmn/osx-ssh-key branch October 5, 2016 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants