{{ message }}
Preliminary Haiku port#3796
Merged
Merged
Conversation
Member
Contributor
Author
|
Yeah, those ones. Now another test that fails is stat() on directories: |
Member
Agreed. A PR that fixed this up would be 👌 |
Contributor
Author
|
Indeed, Hurd uses other st_mode bits too: |
Contributor
Author
|
It seems like libgit2 is doing some black magic on the st_mode fields when passing it around though, using custom value S_IFGITLINK... |
Contributor
Author
|
Ok, next tests... |
Member
|
|
Contributor
Author
|
Yeah ok it handles them as virtual files, but it's confusing. One more example of Linux coders thinking they are alone in the universe and they are always right... Besides BSD uses the value for whiteout entries: http://man7.org/linux/man-pages/man2/fstat.2.html Anyway, shouldn't do any harm as long as it doesn't collide with an even weirder OS where it'd be used for IFREG or IFDIR :-D |
Contributor
Author
|
Ok, here is the full test log now:
|
Contributor
Author
|
Just opened PR #3798. |
Member
That doesn't matter, these values are never written to disk, they're only used internally in the index. As @carlosmn mentioned, those look like Unix modes (and are stored in a stat structure, usually) but they are not, they are hardcoded values, so there's nothing to collide. |
Contributor
Author
|
@ethomson yeah I got that, still quite ugly though 😁 |
Member
|
I'm going to go ahead and merge this - if you have further incremental improvements for haiku, we'd be happy to see new PRs. Thanks! |
Contributor
Author
|
Thanks! |
Contributor
Author
|
Btw, I just checked again, and 5 is actually AF_INET6 on Haiku, so one of the expected fails doesn't happen even when passing non-null pointer. The hardcoded numbers are not even correct on Linux, where 5 is AF_APPLETALK. |
Member
I don't know what you're talking about. Can you link to the code snippet that you're referring to? |
Contributor
Author
Member
|
I see. You're welcome to submit a PR that changes that to a different bogus number. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes libgit2 compile on Haiku.
Currently make test fails due to calling inet_pton() with dst=NULL, which assert()s our implementation. I'm not sure whether I should fix our code or the test though...