{{ message }}
Repository navigation
Conversation
ldm0
self-requested a review
October 21, 2026 12:21
sumerchoudhary78
force-pushed
the
fix/cli-surface-best-effort-readiness-timeout
branch
from
October 21, 2026 14:36
65018fd to
8d9e915
Compare
Contributor
Author
Explain that network-idle and DOM-stable timeouts return the current page, and point to --log-level warn for timeout warnings. Co-authored-by: ldm0 <ldm2993593805@163.com>
ldm0
force-pushed
the
fix/cli-surface-best-effort-readiness-timeout
branch
from
October 22, 2026 13:13
83b7493 to
e3e61ed
Compare
ldm0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
moli fetch --timeouthelp promises a warning even though fetch disables diagnostic logs by default.Clarify that network-idle and DOM-stable timeouts return the current page, and point users to
--log-level warnto display the timeout warnings.Validation:
cargo fmt --allcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --no-fail-fast: 20,530 passed, 18 skippedmoli fetch --helpoutput for the timeout guidance.