Add support for HTTPS proxy by kelunik · Pull Request #72 · leproxy/leproxy · GitHub
Skip to content

Add support for HTTPS proxy - #72

Open
kelunik wants to merge 2 commits into
leproxy:mainfrom
kelunik:tls-proxy
Open

kelunik wants to merge 2 commits into
leproxy:mainfrom
kelunik:tls-proxy

Conversation

@kelunik

@kelunik kelunik commented Nov 13, 2019

Copy link
Copy Markdown

Can be used with php leproxy.php 'https://127.0.0.1:5512?local_cert=/home/kelunik/GitHub/amphp/http-server/tools/tls/localhost.pem'

See https://github.com/amphp/http-client/blob/58c0c19767cb6ade95f29983f0cb540a83dde752/examples/basic/8-proxy.php for a client implementation.

@clue

clue commented Nov 14, 2019

Copy link
Copy Markdown
Member

@kelunik

kelunik commented Nov 14, 2019

Copy link
Copy Markdown
Author

@clue There have been vulnerabilities and weaknesses due to one port being used for both. I think these were mostly due to the client using opportunistic TLS, so they might not be applicable if the client knows whether it wants to use TLS or not. Maybe @paragonie-scott has some input here.

@kelunik

kelunik commented Nov 15, 2019

Copy link
Copy Markdown
Author

@clue Even if both might be used at the same port in the future, there should be a way to force TLS being used.

We can add same port plain and TLS later using http+https as scheme or similar.

@kelunik

kelunik commented Nov 19, 2019

Copy link
Copy Markdown
Author

@clue What's required to get this in?

@clue

clue commented Nov 29, 2019

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants