{{ message }}
refactor: moving signature logic from ethlambda-types to ethlambda-crypto - #541
Merged
MegaRedHand merged 4 commits intoJul 29, 2026
Merged
Conversation
4 tasks
MegaRedHand
reviewed
Jul 28, 2026
MegaRedHand
left a comment
MegaRedHand
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Left a suggestion
Sahilgill24
marked this pull request as ready for review
July 29, 2026 00:32
Contributor
MegaRedHand
approved these changes
Jul 29, 2026
MegaRedHand
left a comment
MegaRedHand
left a comment
Collaborator
There was a problem hiding this comment.
Great work! Thanks for your contribution!
MegaRedHand
added a commit
that referenced
this pull request
Jul 29, 2026
Resolves the overlap with #541, which moved the signature primitives out of `ethlambda-types` and into `ethlambda-crypto` while this branch was rewriting those same primitives for leanVM's internalized XMSS. The two wire-size constants cannot follow `signature.rs` into `ethlambda-crypto`: `types::attestation::XmssSignature` and `types::state::ValidatorPubkeyBytes` are defined in terms of them, and `ethlambda-crypto` already depends on `ethlambda-types`. #541 hit the same constraint and hardcoded `SIGNATURE_SIZE` in `types`. Keep that placement, but source both from leanVM's xmss crate so they track the scheme parameters: main's literal 2536 is the old leanSig size and is wrong for leanVM's wire format. `ethlambda-types` therefore keeps a narrow `xmss` dependency for the two constants only, and `ssz`/`postcard` move to `ethlambda-crypto` along with the signing code that needed them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
porting the lean-sig based signature logic from types crate to crypto crate as mentioned here
It is first of all a cleaner and more idiomatic approach and secondly ethlambda-types crate builds/compiles for the prover crate(zkVM prover), which also leads to dependency conflicts between leansig dependencies and the zkVM sdk dependencies being used. This port removes all leansig dependencies from the ethlambda-types
What Changed
signature.rsfile to the crypto crate along with a extension traitValidatorPublicKeyswith the same methods as before, it helps in avoiding cyclic dependencies and the call sites remain the same.signature.rsfrom the types crate and moved theSIGNATURE_SIZEdirectly to theattestation.rsVerification Checklist
make fmtmake lint(clippy with-D warnings)cargo test --workspace --release— all passing