{{ message }}
Feature: FreeLook Module - #127
Merged
Merged
Conversation
emyfops
approved these changes
Jun 25, 2025
Contributor
There was a problem hiding this comment.
You might as well use the mc property in Lambda
| object FreeLook : Module( | ||
| name = "FreeLook", | ||
| description = "Allows you to look around freely while moving", | ||
| defaultTags = setOf(com.lambda.module.tag.ModuleTag.RENDER, com.lambda.module.tag.ModuleTag.MOVEMENT) |
Contributor
There was a problem hiding this comment.
You can import the enum instead of using the full canonical path
emyfops
suggested changes
Jun 26, 2025
Comment on lines
+107
to
+114
|
|
||
| @ModifyArgs(method = "update", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/render/Camera;setRotation(FF)V")) | ||
| private void onUpdateSetRotationArgs(Args args) { | ||
| if (FreeLook.INSTANCE.isEnabled()) { | ||
| args.set(0, FreeLook.INSTANCE.getCamera().getYawF()); | ||
| args.set(1, FreeLook.INSTANCE.getCamera().getPitchF()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could you add a snippet of the modified method ? Check other mixins for an example
This is crucial for mixin updates on new versions
Contributor
Author
There was a problem hiding this comment.
Do you mean the original source?
Contributor
There was a problem hiding this comment.
Yes, look at other mixins for an example
emyfops
self-requested a review
June 27, 2025 19:58
emyfops
approved these changes
Jun 27, 2025
emyfops
left a comment
emyfops
left a comment
Contributor
There was a problem hiding this comment.
lgtm @Avanatiker what do you think
Contributor
Author
|
Btw this merges into 1.21.5. But I think 1.21.4 is main atm? Can probably back port easily. |
Contributor
Avanatiker
force-pushed
the
feature/freelook-module
branch
from
July 24, 2025 19:55
a91d23d to
04802dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeLook Module
Has some extra settings for more advanced use