{{ message }}
chore: fix typos in httperror.go#2958
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Apr 27, 2026
Contributor
Author
There was a problem hiding this comment.
This is a non-trivial change but it keeps all receivers as pointer receivers. Or else my linter would report:
Struct HTTPError has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation.
Contributor
There was a problem hiding this comment.
Well, it is intentional as this Wrap does not mutate the HTTPError instance returns "immutable-copy wrapping"
Contributor
Author
There was a problem hiding this comment.
Suggested change
| func (he *HTTPError) Wrap(err error) error { | |
| func (he HTTPError) Wrap(err error) error { |
Contributor
Author
Contributor
|
Other than that receiver change looks good. |
Contributor
Author
|
Non-trivial change reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.