{{ message }}
Add NewDefaultFS function to help create filesystem that allows absolute paths#2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
NewDefaultFSfunction to help create filesystem that allows absolute paths withOpenmethod.fs.FS does not like paths like
/tmp/temp.fileeven if fs is created like `os.DirFS("/"). You need to remove leading slash.Also when file is absolute (
/tmp/temp.file) and has same prefix as filesystemos.DirFS("/tmp/")this would not work. EchodefaultFswas working similarly toos.Openand therefore allowed absolute paths.This PR makes
echo.defaultFsto accept absolute path filenames in Open when it matches the filesystem prefix.Relates to #2929