feat: allow targetGroupName instead of targetGroupARN in forward action ingress annotations by pascal-hofmann · Pull Request #4281 · kubernetes-sigs/aws-load-balancer-controller · GitHub
Skip to content

feat: allow targetGroupName instead of targetGroupARN in forward action ingress annotations - #4281

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
pascal-hofmann:action-annotation-with-target-group-name
Aug 5, 2025
Merged

feat: allow targetGroupName instead of targetGroupARN in forward action ingress annotations#4281
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
pascal-hofmann:action-annotation-with-target-group-name

Conversation

@pascal-hofmann

@pascal-hofmann pascal-hofmann commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue

#4280

Description

Allow targetGroupName instead of targetGroupARN in forward action ingress annotations

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2025
@k8s-ci-robot

k8s-ci-robot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2025
@k8s-ci-robot

k8s-ci-robot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Hi @pascal-hofmann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2025
@pascal-hofmann
pascal-hofmann force-pushed the action-annotation-with-target-group-name branch 2 times, most recently from 78b4d74 to dc54465 Compare August 1, 2025 06:02
@pascal-hofmann
pascal-hofmann marked this pull request as ready for review August 1, 2025 06:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from wweiwei-li August 1, 2025 06:12
@pascal-hofmann

pascal-hofmann commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

Hi @M00nF1sh, hi @oliviassss, hi @wweiwei-li,
it would be great to get this reviewed / merged soon. It would save us quite some manual fiddling with different ARNs in different environments.

Thanks in advance,
Pascal

zac-nixon
zac-nixon reviewed Aug 1, 2025
View reviewed changes
Comment thread pkg/ingress/model_build_actions.go
@zac-nixon

zac-nixon commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! I left a comment around some caching which I would consider very important. The LBC already makes a lot of ELB API calls, it would be great to make sure this PR doesn't balloon the call volume.

@zac-nixon

zac-nixon commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2025
@pascal-hofmann
pascal-hofmann force-pushed the action-annotation-with-target-group-name branch from dc54465 to a64b174 Compare August 4, 2025 18:21
@zac-nixon

zac-nixon commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2025
@zac-nixon

zac-nixon commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

/retest

zac-nixon
zac-nixon approved these changes Aug 5, 2025
View reviewed changes

@zac-nixon zac-nixon left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved
/lgtm

Thank you! This looks like a great addition.

We try a monthly release cadence, so looking around September ~1st for this to be released in an official version.

@k8s-ci-robot

k8s-ci-robot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pascal-hofmann, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@k8s-ci-robot
k8s-ci-robot merged commit 38d8ce7 into kubernetes-sigs:main Aug 5, 2025
@pascal-hofmann
pascal-hofmann deleted the action-annotation-with-target-group-name branch August 5, 2025 20:46
@pascal-hofmann

pascal-hofmann commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zac-nixon zac-nixon zac-nixon approved these changes
@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh
@oliviassss oliviassss Awaiting requested review from oliviassss
@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

@zac-nixon zac-nixon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pascal-hofmann @k8s-ci-robot @zac-nixon