You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Watch.stream decides whether to pass watch= or follow= by looking at the wrapped API method docstring.
The generated pod log method now documents follow as split :param follow: and :type follow: bool lines instead of the older :param bool follow: form. Because the watch code only recognized the older form, it passed watch=True to read_namespaced_pod_log, and the generated client rejected that kwarg.
This keeps the existing old-format check and also recognizes the generated split follow docstring, so pod log streaming uses follow=True while normal watch APIs continue to use watch=True.
Special notes for your reviewer:
Added a regression test for the generated pod log docstring format. This is scoped to the Watch.stream argument selection path and does not change generated client files.
Does this PR introduce a user-facing change?
Yes - Watch.stream(v1.read_namespaced_pod_log, ...) now uses follow=True for pod log streaming with the current generated docstring format, instead of failing with an unexpected watch argument.
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
This pull-request has been approved by: goutamadwant Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels.kind/bugCategorizes issue or PR as related to a bug.kind/regressionCategorizes issue or PR as related to a regression from a prior release.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Watch.stream decides whether to pass watch= or follow= by looking at the wrapped API method docstring.
The generated pod log method now documents follow as split :param follow: and :type follow: bool lines instead of the older :param bool follow: form. Because the watch code only recognized the older form, it passed watch=True to read_namespaced_pod_log, and the generated client rejected that kwarg.
This keeps the existing old-format check and also recognizes the generated split follow docstring, so pod log streaming uses follow=True while normal watch APIs continue to use watch=True.
Which issue(s) this PR fixes:
Fixes #2610
Special notes for your reviewer:
Added a regression test for the generated pod log docstring format. This is scoped to the Watch.stream argument selection path and does not change generated client files.
Checked locally with:
Does this PR introduce a user-facing change?
Yes - Watch.stream(v1.read_namespaced_pod_log, ...) now uses follow=True for pod log streaming with the current generated docstring format, instead of failing with an unexpected watch argument.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE