Ability to add custom operation name for request by robbertnoordzij · Pull Request #682 · kobylynskyi/graphql-java-codegen · GitHub
Skip to content

Ability to add custom operation name for request#682

Merged
kobylynskyi merged 3 commits into
kobylynskyi:developfrom
robbertnoordzij:develop
May 11, 2021
Merged

Ability to add custom operation name for request#682
kobylynskyi merged 3 commits into
kobylynskyi:developfrom
robbertnoordzij:develop

Conversation

@robbertnoordzij

@robbertnoordzij robbertnoordzij commented May 6, 2021

Copy link
Copy Markdown
Contributor

Description

Based on the suggestion by @kobylynskyi, I added the ability to override the operation name in queries. While to comment states that a multi request does not have an operation name it is actually possible based on the documentation.

Am I missing something?

Related to #681


Changes were made to:

  • Codegen library

Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequest.java Outdated
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequests.java Outdated
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequest.java Outdated
robbertnoordzij and others added 2 commits May 11, 2021 09:12
…aphQLRequests.java

Co-authored-by: Bogdan Kobylynskyi <92bogdan@gmail.com>
…aphQLRequest.java

Co-authored-by: Bogdan Kobylynskyi <92bogdan@gmail.com>

@kobylynskyi kobylynskyi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbertnoordzij Good job. Thanks for the contribution.

@kobylynskyi kobylynskyi merged commit b6d34be into kobylynskyi:develop May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants