{{ message }}
This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Fix the retry issue with deployment verification#387
Merged
knative-prow-robot merged 1 commit intoApr 4, 2020
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
Contributor
There was a problem hiding this comment.
@houshengbo: 0 warnings.
Details
In response to this:
Fixes #
Proposed Changes
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Contributor
Member
|
@houshengbo |
Author
|
@aliok I added in the comments of the PR. |
Member
houshengbo
pushed a commit
to houshengbo/serving-operator
that referenced
this pull request
May 18, 2020
houshengbo
pushed a commit
to houshengbo/serving-operator
that referenced
this pull request
May 18, 2020
houshengbo
pushed a commit
to houshengbo/serving-operator
that referenced
this pull request
May 18, 2020
houshengbo
pushed a commit
to houshengbo/serving-operator
that referenced
this pull request
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
false, err, which would run the check only once, but we need to returnfalse, nil, till we reach the desired state. This PR made the correct changes for the retry mechanism.Release Note