Bump to manifestival 0.4.0 by jcrossley3 · Pull Request #338 · knative/serving-operator · GitHub
Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Bump to manifestival 0.4.0#338

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
jcrossley3:mf4
Mar 11, 2020
Merged

Bump to manifestival 0.4.0#338
knative-prow-robot merged 2 commits into
knative:masterfrom
jcrossley3:mf4

Conversation

@jcrossley3

Copy link
Copy Markdown
Contributor

Fixes a pretty gnarly bug where transformers using Scheme.Convert don't work.

This was exposed by #337

Fixes a pretty gnarly bug where transformers using Scheme.Convert
don't work.
We delete the deployments first, hopefully preventing the webhook
controller from recreating the secret after it's deleted.
@k4leung4

Copy link
Copy Markdown

@chizhg

chizhg commented Mar 11, 2020

Copy link
Copy Markdown

@jcrossley3 can you type @googlebot I consent. here? This seems to be a googlebot's problem.

@houshengbo houshengbo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants