Drop knative.dev/serving as dependency by skaslev · Pull Request #249 · knative/serving-operator · GitHub
Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Drop knative.dev/serving as dependency#249

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
skaslev:drop-serving
Jan 13, 2020
Merged

Drop knative.dev/serving as dependency#249
knative-prow-robot merged 1 commit into
knative:masterfrom
skaslev:drop-serving

Conversation

@skaslev

@skaslev skaslev commented Jan 9, 2020

Copy link
Copy Markdown

Since 7a6abca serving-operator is no longer using serving's
Istio client so there's no need depending on knative.dev/serving anymore.

Since 7a6abca serving-operator is no longer using serving's
Istio client so there's no need depending on knative.dev/serving anymore.
@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Jan 9, 2020
@knative-prow-robot

Copy link
Copy Markdown
Contributor

@skaslev

skaslev commented Jan 9, 2020

Copy link
Copy Markdown
Author

/cc @houshengbo

@k4leung4

k4leung4 commented Jan 9, 2020

Copy link
Copy Markdown

/ok-to-test

@houshengbo houshengbo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot merged commit 80c4c8c into knative:master Jan 13, 2020
@skaslev skaslev deleted the drop-serving branch January 14, 2020 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants