{{ message }}
This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Propagating configured imagePullSecrets to the Image#229
Merged
knative-prow-robot merged 1 commit intoDec 3, 2019
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
Contributor
There was a problem hiding this comment.
@garron: 0 warnings.
Details
In response to this:
Fixes #220
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
houshengbo
approved these changes
Dec 3, 2019
houshengbo
left a comment
houshengbo
left a comment
There was a problem hiding this comment.
/approve
/lgtm
Thank @garron for the fix!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221