{{ message }}
This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Configure controller to trust registries with self-signed certs#219
Merged
Conversation
Modified CRD and ran update-codegen.sh
An e2e test will require a well-known self-signed registry, but I did verify it worked manually
knative-prow-robot
left a comment
knative-prow-robot
left a comment
Contributor
There was a problem hiding this comment.
@jcrossley3: 4 warnings.
Details
In response to this:
Fixes #210
Proposed Changes
- Add configuration to the
KnativeServingCRD- Use that config to setup the
VolumeMountsandEnvVarsin the controller deployment per https://knative.dev/docs/serving/tag-resolution/
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
mattmoor
reviewed
Nov 13, 2019
mattmoor
reviewed
Nov 13, 2019
jcrossley3
force-pushed
the
custom-certs
branch
from
a6a4d67 to
7ec6004
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This seems wrong, but maybe not quite as wrong as the client sending empty structs for all the optional fields in the CR.
|
The following is the coverage report on the affected files.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210
Proposed Changes
KnativeServingCRDVolumeMountsandEnvVarsin the controller deployment per https://knative.dev/docs/serving/tag-resolution/