{{ message }}
Repository navigation
fix: cut public shared highlights to 100 words or 600 characters - #155
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a15cbe-ef2f-726a-a933-93846fb847ed Co-authored-by: Amp <amp@ampcode.com>
…ing paragraphs Amp-Thread-ID: https://ampcode.com/threads/T-01a15cbe-ef2f-726a-a933-93846fb847ed Co-authored-by: Amp <amp@ampcode.com>
… note links and line breaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
A shared highlight's public page (
/h/…) showed the whole highlight, up to 20,000 characters, and its note, up to 10,000. That could republish most of an article, against the terms' promise that public pages only quote short passages.What changes
getPublicShare), not when it is saved: shares made before this are cut too, and the stored snapshot keeps the full text, so the owner's "changed since shared" check still works.Verification
pnpm verify,e2e/share-links.spec.ts, and a long share checked in the browser.Risk and follow-ups