{{ message }}
Repository navigation
feat: create an account in the iPhone app - #148
Merged
Merged
Conversation
…ogle and GitHub, with an invite /app/sign-up/code checks the invite and emails a code; /app/sign-up creates the account, verified, once the code checks out, or with Apple's sheet; the provider sheet takes sign_up=1 and the invite. The invite is consumed only when a user is created. Amp-Thread-ID: https://ampcode.com/threads/T-01a15729-a41b-749a-be6e-639752903e39 Co-authored-by: Amp <amp@ampcode.com>
A sign-up screen behind "Create an account": the invite, then Apple, Google or GitHub, or a name, email and password confirmed by an emailed code. The code field spaces its digits, not its placeholder. Amp-Thread-ID: https://ampcode.com/threads/T-01a15729-a41b-749a-be6e-639752903e39 Co-authored-by: Amp <amp@ampcode.com>
…and the sign-up's limit matches the web's From the review: a used-up invite no longer refuses, and revokes, an Apple ID that has an account; a code works only for its own address (tested).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The iPhone app could only sign in: a new reader had to create an account on the web first. This adds sign-up in the app, with the same invite rules as the web.
What changes
/app/sign-upand the provider sheet started withsign_up=1can, through the same user-create hook as the web.Accept-Language.Verification
pnpm verifyandpnpm ci:local(static, unit, build) pass. In e2e, 304 passed. "Getting started card" failed all retries under load, as it flaked before; run alone it passed 3 of 3. It is unrelated to sign-up.Risk and follow-ups
docs/security.md: "The app's sign-up".