{{ message }}
catalog: add getVersionedPluginCatalog overload accepting a planNames…#39
Open
jutur wants to merge 1 commit into
Open
catalog: add getVersionedPluginCatalog overload accepting a planNames…#39jutur wants to merge 1 commit into
jutur wants to merge 1 commit into
Conversation
… hint Adds a default method that accepts a Set<String> planNames alongside the existing properties and context parameters. Kill Bill core already knows which plans are needed during invoice generation (from the billing event set) and can pass them here so that catalog plugins managing large catalogs can return a shallow subset rather than the full catalog, reducing serialization and processing overhead. The default implementation delegates to the existing full-catalog method, so existing plugin implementations require no changes. Fixes killbill/killbill#2258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default method that accepts a Set planNames alongside the existing properties and context parameters. Kill Bill core already knows which plans are needed during invoice generation (from the billing event set) and can pass them here so that catalog plugins managing large catalogs can return a shallow subset rather than the full catalog, reducing serialization and processing overhead.
The default implementation delegates to the existing full-catalog method, so existing plugin implementations require no changes.
Fixes killbill/killbill#2258