Deliver conditioned exchanger profiles with verified animated results by khalil-official · Pull Request #1 · khalil-official/thermal-streams · GitHub
Skip to content

Deliver conditioned exchanger profiles with verified animated results - #1

Merged
khalil-official merged 3 commits into
mainfrom
results/verification-suite
Oct 18, 2026
Merged

khalil-official merged 3 commits into
mainfrom
results/verification-suite

Conversation

@khalil-official

@khalil-official khalil-official commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Thermal Streams now evaluates counter-flow temperature fields reliably in either capacity orientation, including NTU=100. The previous forward formula could round a small terminal gap to zero and return a cold inlet 65 K too hot; the repaired normalized-integral evaluation agrees with an 80-digit reference within 5.7e-14 K across 15 saved cases.

  • Evaluate a decaying exponential from the conditioned boundary instead of amplifying a tiny subtracted gap. Use the exact equal-capacity limit and cancellation-resistant effectiveness near C_r=1.
  • Make LMTD symmetric and robust over wide positive input scales; normalize validated configuration inputs and reject nonrepresentable derived ratings.
  • Add 29 meaningful conditioning/input regressions, including full-field high-precision comparisons and independent RK4 integration from the stable end. All 770 parametrized test cases pass locally.
  • Regenerate the 48-frame white/no-grid GIF and clean figures. Save all 11,568 animated temperature samples, 250 heat-balance rows, the before/after comparison plot and its CSV/JSON data. Update equations, numerical limits, API and reproduction instructions.

These are numerical equation and implementation checks, not experimental validation. The GIF compares steady exchangers as area grows; terminal-LMTD checks retain their documented conditioning limits. Current main history and calendar disclosure are preserved.

Copilot AI balanced review requested due to automatic review settings October 17, 2026 23:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@khalil-official khalil-official changed the title Results and documentation: verification suite, figures and animated profiles Deliver conditioned exchanger profiles with verified animated results Oct 18, 2026
@khalil-official
khalil-official merged commit 36fc789 into main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants