{{ message }}
Repository navigation
Remove the in-container Envoy proxy - #483
Draft
sjmiller609 wants to merge 1 commit into
Draft
sjmiller609 wants to merge 1 commit into
sjmiller609 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove the in-container Envoy proxy from both public browser images:
Compatibility / deployment gate
Breaking change: do not deploy these images while any allocation, fallback, or snapshot configuration still passes
--proxy-server=https://127.0.0.1:3128. That listener no longer exists. Update those configurations to use an external proxy (or direct networking) first. LegacyXDS_SERVERconfiguration no longer starts a local proxy.Generic Chromium proxy flags and proxy environment variables are unchanged. This PR does not change deployment routing or remove the instance credentials used by other services.
Validation
TestBrowserNetworkingWithoutLocalProxy: headful/headless × direct/external HTTP proxy, including absence of the Envoy binary, config, and certificates.cmd/shellexcluded. An existing Chromium temporary-directory cleanup failure inlib/devtoolsproxypassed on rerun; the subsequent complete non-e2e run passed.cmd/shell/main.go:160UUID/string argument mismatch, reproduced on unmodified main (d260d1b).