{{ message }}
Repository navigation
Enforce non-root customer services with RUN_AS_ROOT - #482
Draft
sjmiller609 wants to merge 1 commit into
Draft
sjmiller609 wants to merge 1 commit into
sjmiller609 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Extend
RUN_AS_ROOTfrom the Chromium user setting to the privilege policy for customer-facing image services.kernelwithno_new_privs. Reject exec/spawn identity overrides in non-root mode.Compatibility
RUN_AS_ROOT=falseand an unset value now remove root access through the process and filesystem APIs, not just Chromium.RUN_AS_ROOT=trueretains root access. Launch-script defaults are unchanged. Use a fresh container or guest when switching modes; root-dependent callers must adapt or explicitly select root mode.Validation
dbus; verified that root configuration stayed unchanged, the injected command did not gain root access, and the API remained unprivileged. Tested with and without tmpfs/run.cmd/shell. Full tests andgo vet ./...hit the existingcmd/shell/main.go:160UUID/string type error, also reproduced onmain. Vet passes with that package excluded. A Chromium temporary-directory cleanup failure inlib/devtoolsproxypassed on rerun.bash -npasses for the changed scripts;git diff --checkpasses.