{{ message }}
Repository navigation
Conversation
akxue
marked this pull request as ready for review
October 15, 2026 23:56
akxue
force-pushed
the
hypeship/strip-network-credentials
branch
from
October 19, 2026 17:25
c376f74 to
a6f65c2
Compare
Sayan-
requested changes
Oct 19, 2026
Sayan-
left a comment
Contributor
There was a problem hiding this comment.
holding while we discuss first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

context
network telemetry published each request's body (
post_data) and every request and response header as CDP reported them. that's the same view as the DevTools Network panel, which assumes the person reading it is the person using the browser. telemetry is read elsewhere (stored events, SSE, OTLP export), so it should default to what's safe to share.this applies sanitization to network telemetry, starting with Chrome's sanitized HAR export defaults (Chrome 130+), which leave out
Cookie,Set-CookieandAuthorization. request bodies can hold form input, including passwords, so they're left out for now and come back once a redaction layer can remove sensitive fields before events are published.changes
network_requestno longer includespost_data, and the pending request state no longer holds it.Authorization,Proxy-Authorization,CookieandSet-Cookie, matching any capitalization.post_datastays in the schema as an optional field so existing clients keep decoding events. the openapi descriptions, regeneratedoapi.goand the cdpmonitor README describe what's left out.#462 adds headers from
requestWillBeSentExtraInfo/responseReceivedExtraInfoand arequest_headersfield on responses. those should go throughpublishedHeadersas well; whichever PR merges second needs a rebase.testing
TestNetworkEvents/credentials_left_outsends canary values in the body and each credential header and checks none are published.KERNEL_CDPMONITOR_CHROME_E2E=1 go test ./lib/cdpmonitor/against real Chromium. the frames and workers capture tests now assertpost_datais absent.go test -race $(go list ./... | grep -v /e2e$)make test).Note
Medium Risk
Changes what network telemetry exposes (breaking for consumers that relied on post_data or auth headers) but reduces credential leakage; response bodies may still contain secrets.
Overview
Sanitizes CDP network telemetry so stored/SSE events no longer carry secrets that DevTools would show only to the browser operator.
network_requestevents stop publishingpost_dataand pending request state no longer retains bodies. Request and response headers are filtered throughpublishedHeaders, droppingAuthorization,Proxy-Authorization,Cookie, andSet-Cookie(any casing). Truncated response bodies for text MIME types are unchanged.OpenAPI, regenerated
oapi.go, and the cdpmonitor README document the new behavior;post_dataremains optional in the schema for backward-compatible decoding. Tests cover credential stripping (credentials_left_out) and Chrome e2e cases now expect absent request bodies.Reviewed by Cursor Bugbot for commit a6f65c2. Bugbot is set up for automated code reviews on this repo. Configure here.