fix error if max_number is a multiple of 10 by htkuan · Pull Request #511 · keon/algorithms · GitHub
Skip to content

fix error if max_number is a multiple of 10 - #511

Merged
keon merged 1 commit into
keon:masterfrom
htkuan:fix/radix_sort
Jul 29, 2019
Merged

keon merged 1 commit into
keon:masterfrom
htkuan:fix/radix_sort

Conversation

@htkuan

@htkuan htkuan commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

(Put an X inside the [ ] to denote check mark [X].)

  • [X ] If creating a new file :

    • [X ] added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue
  • other

if max_number is a multiple of 10, like [1,2,3,4,5,6,7,8,9,10], then result will be [10,1,2,3,4,5,6,7,8,9]

@coveralls

Copy link
Copy Markdown

@htkuan

htkuan commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

@keon I think that is kind of ci error...

@goswami-rahul goswami-rahul left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix :)

@goswami-rahul

Copy link
Copy Markdown
Collaborator

@keon
keon merged commit 321d492 into keon:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants