{{ message }}
Closed
Conversation
| return res | ||
|
|
||
|
|
||
| def generate_parenthesis_(n): |
Collaborator
There was a problem hiding this comment.
Please add tests in the tests folder (tests/test_backtrack.py).
Rename the new version as generate_parenthesis_v2(), also change the original version name to generate_parenthesis_v1().
Author
There was a problem hiding this comment.
there are some problems, let me correct it and push it later.
christianbender
requested changes
Jul 29, 2018
| res.append(s) | ||
| if left > 0: | ||
| add_pair(res, s+"(", left-1, right) | ||
| if right > 0 && left<right: |
Collaborator
There was a problem hiding this comment.
Write and instead of &&
Merged
Collaborator
|
@RenliangShi Could you solve the problem in |
ghost
closed this
Collaborator
|
Hi @RenliangShi, why do you close the PR? You intend to create new PR for it? |
Author
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.