{{ message }}
Repository navigation
Vala: fix new compiler errors and memory corruption #663 - #747
Open
asarhaddon wants to merge 27 commits into
Open
asarhaddon wants to merge 27 commits into
asarhaddon wants to merge 27 commits into
Conversation
As is, it was triggering a new error message about weak references inside the list.
Doubly-linked lists are efficient at both ends.
A global list of reference to built-in functions make the garbage collector harder to check.
A check/error message couple was inconsistent.
A warning complains that the possible exception propagation is implicit. Remove the exception, this is a compile-time issue, and should be a no op or crash the program.
This slightly simplifies the garbage collection.
Replace explicit subclasses of BuiltinFunction with delegate attributes. Use lambda forms for + and <. In step1, make explicit that the reader can throw an exception (removing a warning). Handle all exceptions consistently in steps9A.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to simplify a lot the garbage collection, but now all program variables are roots by defaults so there should be no memory leaks. At least valgrind does not complain and all allocations made by the gc are eventually deallocated.
The memory corruption in issue #663 is fixed as a side effect.