{{ message }}
Repository navigation
printbuf_memset: maintain the NUL-termination invariant - #980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
printbuf_memset()violates the invariant every other printbuf operation maintains —buf[bpos] == '\0'— because it never NUL-terminates at the new position and doesn't reserve space for the terminator (printbuf.c):Any consumer reading
pb->bufas a C string immediately after anindent()(which callsprintbuf_memset) reads uninitialized bytes. Latent today because serializers append before reading, but it is a foot-gun for any new consumer.Fix
Reserve
size_needed + 1and NUL-terminate at the newbpos, matchingprintbuf_memappend's contract.Verification
29/29 ctest tests pass (printbuf + serialization suites).