{{ message }}
Repository navigation
Add per-operation hooks for framework diagnostics - #850
Open
GtechGovind wants to merge 2 commits into
Open
GtechGovind wants to merge 2 commits into
GtechGovind wants to merge 2 commits into
Conversation
GtechGovind
marked this pull request as ready for review
October 2, 2026 09:45
…t-hook # Conflicts: # Source/SourceKittenFramework/Module.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
I added per-operation
EventHookvalues so framework consumers can collect progress and diagnostic messages without writing them to stderr.Addresses #22.
Validation
swift test --filter EventHookTests: 19 tests passed.swift build -c release: passed.lint --strict: zero violations across 79 files.swift test: 95 tests, six failures. An untouched checkout of the same upstream commit has 76 tests and the same six failures on this host (Xcode 27.0 / Swift 6.4):ModuleTests.testCommandantDocs,ModuleTests.testCommandantDocsSPM,ModuleTests.testSpmDefaultModule,SourceKitTests.testIndex,SourceKitTests.testSwiftDeclarationAttributeKind, andSwiftDocsTests.testBicycle. These involve the legacy Xcode sample, SwiftPM build-manifest compatibility, and compiler-dependent fixtures.xcodebuild -scheme SourceKitten-Package -parallel-testing-enabled NO test -destination platform=macOS: built and began running tests, but stalled for over five minutes in the existingClangTranslationUnitTests.testBasicObjectiveCDocs; I stopped the run. It is not a completed validation result.