validate selfhosted options by paulwilljones · Pull Request #361 · jetstack/version-checker · GitHub
Skip to content

validate selfhosted options#361

Merged
davidcollom merged 1 commit into
mainfrom
fix-315
Apr 18, 2025
Merged

validate selfhosted options#361
davidcollom merged 1 commit into
mainfrom
fix-315

Conversation

@paulwilljones

Copy link
Copy Markdown

No description provided.

@paulwilljones

Copy link
Copy Markdown
Author

Comment thread cmd/app/options.go
envPrefix, envSelfhostedPrefix, envSelfhostedHost,
))
fs.StringVar(&o.selfhosted.Host,
fs.StringVar(&o.selfhosted.CAPath,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidcollom I think this had been incorrectly set to Host, seems like the flag wasn't going to the right field of CAPath?

@paulwilljones

Copy link
Copy Markdown
Author

@davidcollom davidcollom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and agree, the capath option was using the wrong field 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants