Implemented Array.prototype.filter() by dbatyai · Pull Request #89 · jerryscript-project/jerryscript · GitHub
Skip to content

Implemented Array.prototype.filter() - #89

Closed
dbatyai wants to merge 1 commit into
jerryscript-project:masterfrom
dbatyai:array_prototype_filter
Closed

Implemented Array.prototype.filter()#89
dbatyai wants to merge 1 commit into
jerryscript-project:masterfrom
dbatyai:array_prototype_filter

Conversation

@dbatyai

@dbatyai dbatyai commented May 21, 2015

Copy link
Copy Markdown
Member

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

@ILyoan ILyoan mentioned this pull request May 21, 2015
Closed
25 tasks done
@galpeter galpeter added this to the ECMA builtins milestone May 21, 2015
@dbatyai dbatyai added the ecma builtins Related to ECMA built-in routines label May 22, 2015
@galpeter

galpeter commented May 26, 2015

Copy link
Copy Markdown
Contributor

ruben-ayrapetyan
ruben-ayrapetyan reviewed May 26, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp Outdated

@ruben-ayrapetyan ruben-ayrapetyan May 26, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of step 3, isn't it?

@ruben-ayrapetyan ruben-ayrapetyan self-assigned this May 26, 2015
ruben-ayrapetyan
ruben-ayrapetyan reviewed May 27, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp Outdated

@ruben-ayrapetyan ruben-ayrapetyan May 27, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the assertion to ecma_is_completion_value_normal_true (put_comp_value).

@dbatyai

dbatyai commented May 28, 2015

Copy link
Copy Markdown
Member Author

I've updated the patch.

@egavrin

egavrin commented May 28, 2015

Copy link
Copy Markdown
Contributor 
/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp: In function ‘ecma_completion_value_t ecma_builtin_array_prototype_object_filter(ecma_value_t, ecma_value_t, ecma_value_t)’:
/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp:794:49: error: ‘to_object_comp’ was not declared in this scope
     func_object_p = ecma_get_object_from_value (to_object_comp);
                                                 ^
compilation terminated due to -Wfatal-errors.

ruben-ayrapetyan
ruben-ayrapetyan reviewed May 28, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp Outdated

@ruben-ayrapetyan ruben-ayrapetyan May 28, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the to_object_comp? Why should it be freed?

@dbatyai

dbatyai commented May 28, 2015

Copy link
Copy Markdown
Member Author

@egavrin, @ruben-ayrapetyan sorry, fixed

@dbatyai @szledan
Implemented Array.prototype.filter()
a80282a 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@ruben-ayrapetyan

ruben-ayrapetyan commented May 28, 2015

Copy link
Copy Markdown

make push

@egavrin

egavrin commented May 28, 2015

Copy link
Copy Markdown
Contributor

@dbatyai @ruben-ayrapetyan Nope ^_^, wrong email

+ make precommit -j4
�[1;33m Signed-off-by message is incorrect. The following line should be at the end of the ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 commit's message: 'JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu'.

@ruben-ayrapetyan

ruben-ayrapetyan commented May 28, 2015

Copy link
Copy Markdown

@egavrin , ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 seems to be another commit.
The commit in the pull request is a80282a.

In other, already merged, commits the dbatyai.u-szeged@partner.samsung.com e-mail is used.

@egavrin

egavrin commented May 28, 2015

Copy link
Copy Markdown
Contributor

@ruben-ayrapetyan ah, my bad.
make push

@dbatyai

dbatyai commented May 28, 2015

Copy link
Copy Markdown
Member Author

@dbatyai dbatyai closed this May 28, 2015
@ruben-ayrapetyan ruben-ayrapetyan removed their assignment May 28, 2015
@dbatyai
dbatyai deleted the array_prototype_filter branch June 9, 2015 14:04
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

5 participants

@dbatyai @galpeter @egavrin @ruben-ayrapetyan @tilmannOSG