Implement Array.prototype.splice(). by bzsolt · Pull Request #86 · jerryscript-project/jerryscript · GitHub
Skip to content

Implement Array.prototype.splice(). - #86

Closed
bzsolt wants to merge 1 commit into
jerryscript-project:masterfrom
bzsolt:array_prototype_splice
Closed

Implement Array.prototype.splice().#86
bzsolt wants to merge 1 commit into
jerryscript-project:masterfrom
bzsolt:array_prototype_splice

Conversation

@bzsolt

@bzsolt bzsolt commented May 21, 2015

Copy link
Copy Markdown
Member

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com

@ILyoan ILyoan mentioned this pull request May 21, 2015
Closed
25 tasks done
@galpeter galpeter added this to the ECMA builtins milestone May 21, 2015
@dbatyai dbatyai added the ecma builtins Related to ECMA built-in routines label May 22, 2015
@dbatyai

dbatyai commented May 23, 2015

Copy link
Copy Markdown
Member

@dbatyai dbatyai closed this May 23, 2015
@dbatyai dbatyai reopened this May 23, 2015
galpeter
galpeter reviewed May 26, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp Outdated

@galpeter galpeter May 26, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK: the * should be at the variable.

@bzsolt

bzsolt commented May 26, 2015

Copy link
Copy Markdown
Member Author

@galpeter fixed

galpeter
galpeter reviewed May 26, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp

@galpeter galpeter May 26, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the arg_index 2?

@bzsolt bzsolt May 26, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the first two argument are the start_index and the delete_count usually.
If the args_number is less than or equal to 2, then the condition of the loop will be false (we shouldn't put items into the array).

@galpeter galpeter May 26, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, okay.
lgtm

@egavrin

egavrin commented May 27, 2015

Copy link
Copy Markdown
Contributor

make push

@egavrin egavrin self-assigned this May 27, 2015
egavrin
egavrin reviewed May 27, 2015
View reviewed changes
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp Outdated

@egavrin egavrin May 27, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add blank line before if, please.

Zsolt Borbély
Implement Array.prototype.splice().
07e269f 
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
@galpeter

galpeter commented May 27, 2015

Copy link
Copy Markdown
Contributor

@galpeter galpeter closed this May 27, 2015
@bzsolt
bzsolt deleted the array_prototype_splice branch June 1, 2015 13:35
@bzsolt bzsolt mentioned this pull request Jun 22, 2015
Closed
@zherczeg zherczeg mentioned this pull request Feb 5, 2016
Closed
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

4 participants

@bzsolt @dbatyai @egavrin @galpeter