{{ message }}
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
There should be an assert(false) after the reduceRight call.
25 tasks done
lvidacs
force-pushed
the
array_prototype_reduceright
branch
from
May 29, 2015 13:39
503d889 to
3a1653e
Compare
Contributor
Author
|
Updated based on review comments (also from reduce). |
Contributor
There was a problem hiding this comment.
As I see the accumulator and num_p variables are only used in the following else block, could we move them there?
lvidacs
force-pushed
the
array_prototype_reduceright
branch
from
June 1, 2015 15:02
fc85657 to
0960607
Compare
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com
lvidacs
force-pushed
the
array_prototype_reduceright
branch
from
June 1, 2015 15:16
0960607 to
3e58541
Compare
Contributor
Author
|
The patch is updated. |
Contributor
|
AFAIK: looks good to me |
Contributor
|
|
Contributor
This was referenced May 17, 2020
This was referenced Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs lvidacs.u-szeged@partner.samsung.com