Activity

1. jerone commented on Dec 10, 2015

   

   jerone

   on Dec 10, 2015

   Owner

   More actions

   Underlines :

   I kind of left this intentionally to let users know that's a link now.

   and marks it

   This is somewhat a feature from GitHub. If you disable the userscript it lets you select the whole user+branch, I guess for easy coping. Now that this is a link, GitHub's feature is probably unnecessary.
2. rugk commented on Dec 10, 2015

   

   rugk

   on Dec 10, 2015

   Author

   More actions

   @jerone commented on 10. Dez. 2015, 21:45 MEZ:

   I kind of left this intentionally to let users know that's a link now.

   But as you can see it is really only the character : (and this character is not in every PR). I mean should not it be either the whole branch name or not be underlined at all?

   This is somewhat a feature from GitHub. If you disable the userscript it lets you select the whole user+branch, I guess for easy coping. Now that this is a link, GitHub's feature is probably unnecessary.

   Ah not really in my test:
   

   However I also could not reproduce the marking with your userscript anymore after I reenabled this...
3. jerone commented on Dec 10, 2015

   

   jerone

   on Dec 10, 2015

   Owner

   More actions

   Ah not really in my test:

   You have to click left from the username. It's kind of a bug that this feature doesn't work on children of an .user-select-contain element (probably a left-over from latest site update)...

   $(document).on("click", ".user-select-contain", function() {
           var t, n;
           n = window.getSelection(),
           n.rangeCount && (t = n.getRangeAt(0).commonAncestorContainer,
           e(this, t) || n.selectAllChildren(this))
       }))
   

   However I also could not reproduce the marking with your userscript anymore after I reenabled this...

   After navigating to another page and back the feature is back again (probably also a bug).
4. jerone

   added a commit that references this issue on Dec 10, 2015

   Show underline (fixes #93);

   This issue will close once commit 0369357 is merged into the 'master' branch.

   0369357
5. jerone

   closed this as completedin 0369357on Dec 10, 2015
6. rugk commented on Dec 10, 2015

   

   rugk

   on Dec 10, 2015

   Author

   More actions

   You have to click left from the username.

   Eh, what?
   I clicked everywhere there and it did not worked. (just tried it again)

   However this does not really matter as I do not want to use it anyway. 😃