feat: custom modelfitargs for linear models by yawetse · Pull Request #226 · javascriptdata/scikit.js · GitHub
Skip to content

feat: custom modelfitargs for linear models - #226

Merged
dcrescim merged 2 commits into
mainfrom
ye-modelargs
May 19, 2022
Merged

dcrescim merged 2 commits into
mainfrom
ye-modelargs

Conversation

@yawetse

@yawetse yawetse commented May 19, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@netlify

netlify Bot commented May 19, 2022 •

Copy link
Copy Markdown

@dcrescim

dcrescim commented May 19, 2022 •

Copy link
Copy Markdown
Collaborator

Looks great @yawetse .

It seems if you want to create a custom callback, you have to wrap it in tf.customCallback. I didn't realize this either until I found this issue, and this stackoverflow post. I added test cases to make sure it works, and serializes well.

@dcrescim
dcrescim merged commit 60d99c8 into main May 19, 2022
@dcrescim
dcrescim deleted the ye-modelargs branch May 19, 2022 04:51
@yawetse

yawetse commented May 19, 2022 via email

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants