Variables by javier123454321 · Pull Request #93 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Variables#93

Merged
joaquinelio merged 6 commits intojavascript-tutorial:masterfrom
javier123454321:variables
Jun 8, 2020
Merged

Variables#93
joaquinelio merged 6 commits intojavascript-tutorial:masterfrom
javier123454321:variables

Conversation

@javier123454321
Copy link
Copy Markdown

@javier123454321 javier123454321 commented Sep 2, 2019

Primera traducción y primera contribución.
Utilizé la segunda persona formal (usted) al referirme al lector del artículo.

@javascript-translate-bot javascript-translate-bot requested a review from a team September 2, 2019 03:37
@iliakan iliakan mentioned this pull request Sep 2, 2019
Open
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 2, 2019 •
edited
Loading

@tscandalitta
Copy link
Copy Markdown
Collaborator

tscandalitta commented Sep 8, 2019

En el tutorial nos venimos refiriendo al usuario como "tú" y no como "usted". Podrías corregirlo?

@Giorgiosaud
Copy link
Copy Markdown
Contributor

Giorgiosaud commented Sep 11, 2019

/done

@javier123454321
Copy link
Copy Markdown
Author

javier123454321 commented Sep 23, 2019

Lamento la demora, aquí estan estas correcciones, espero poder dedicarle mas tiempo en el futuro cercano y poder progresar mas rápido

joaquinelio
joaquinelio requested changes Jun 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@joaquinelio joaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax o @ezzep66 Revisen, avisen y lo edito y hago merge
Cierto que faltan los ejercicios, pero
Está buena, no rompe estructura, es largo y tradujo hasta los link externos al sitio ES
Oops! ¿Qué tan importante es firmar eso? ¿Propiedad intelectual?

Comment thread 1-js/02-first-steps/04-variables/article.md
Comment thread 1-js/02-first-steps/04-variables/article.md Outdated
Comment thread 1-js/02-first-steps/04-variables/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jun 3, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
Copy link
Copy Markdown
Contributor

EzequielCaste commented Jun 3, 2020

/done

@vplentinax
Copy link
Copy Markdown
Contributor

vplentinax commented Jun 5, 2020

Se puede hacer merge a esto o no¿? @ezzep66 @joaquinelio

joaquinelio
joaquinelio requested changes Jun 8, 2020
View reviewed changes
Comment thread 1-js/02-first-steps/04-variables/article.md Outdated
Comment thread 1-js/02-first-steps/04-variables/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jun 8, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio merged commit f74c8ae into javascript-tutorial:master Jun 8, 2020
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jun 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCaste EzequielCaste EzequielCaste left review comments

@joaquinelio joaquinelio joaquinelio requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@javier123454321 @CLAassistant @tscandalitta @Giorgiosaud @javascript-translate-bot @EzequielCaste @vplentinax @joaquinelio